Shipping Method selection is wiped out when reloading the Checkout page

chapagain commented 1 year ago

Steps to reproduce:

Go to the checkout page
Select any shipping method
Click "Next" button and go to the Payment section of the Checkout page
Go to homepage
Come back to checkout page
Or, you can reload the checkout page by opening the URL <host>/checkout

Expected result:

The radio button of the shipping method selected above should be checked/selected. Basically, the shipping method selection should be preserved.

Actual result:

No shipping method is selected.

This seems to be a requirement for the ShipperHQ module.

Wiping out shipping method selection was added 4 years ago and modified again 1 year ago https://github.com/shipperhq/module-shipper/commit/af62626f5beb4a566329274c684a73dc259f01f5#diff-441de581123fb1e95f58a45c0377a5b1eb86febb07842048ef90f7bd2fc56536L70-R79

Why was this needed/added?

Issue

The above-mentioned issue (wiping out the selected shipping method) happens even if the ShipperHQ module is disabled from Magento admin (STORES > Configuration > SALES > Delivery Methods > ShipperHQ > Enabled = No)

Wiping out selected shipping method on checkout/cart page should NOT happen if the ShipperHQ module is disabled from Magento admin configuration settings.

shqsupport commented 1 year ago

Hi @chapagain

I apologize for the delay in getting back to you on this issue you are experiencing. Disabling a module in the Magento Admin panel does not remove all functionality. To disable module-shipper completely requires it to be done via the command line. The below document can walk you through those steps in case you need them. https://docs.shipperhq.com/disable-uninstall-magento-extension/#Magento_2

Please let us know if you have any further questions. Have a great day! Peter ShipperHQ Support Engineer

chapagain commented 1 year ago

Thanks for your reply. I was more concerned with the module causing issues after it's installed but not enabled from Magento admin.

We were thinking of keeping the shipperhq module installed but disabled from Magento admin for some time. But, because of the mentioned issue, it seems we cannot do that. So, if we are not enabling the module then we have to completely uninstall the module. Correct?

shqsupport commented 1 year ago

Hi @chapagain

The module does not need to be uninstalled, but it does need to be disabled. The admin panel prevents rates from being requested, but is not able to disable all components of the modules. To do that please follow the below instructions. If

From the command line disable the modules via:

_php bin/magento module:disable --clear-static-content ShipperHQ_Common ShipperHQ_Logger ShipperHQShipper

If you have any of the optional modules enabled these will can be disabled similarly to the above command:

_php bin/magento module:disable --clear-static-content ShipperHQ_Pickup ShipperHQ_Option ShipperHQCalendar

Lastly, run the standard cleanup commands:

php bin/magento setup:upgrade php bin/magento setup:di:compile php bin/magento indexer:reindex php bin/magento cache:clean

Have a great weekend, Peter

shipperhq / module-shipper