shipperhq / module-shipper

Base ShipperHQ Repo
Open Software License 3.0
21 stars 21 forks source link

Checkout Breaks After Signing In As Customer #72

Closed pioneerathletics closed 4 years ago

pioneerathletics commented 4 years ago

I’ve had this problem crop up after updating to the latest version of ShipperHQ and Magento. I’ll go through to the checkout process and either the checkout won’t load at all or the order’s tax won’t display.

I’ve checked a few orders but it seems to break after I sign in and purchase as a customer (within a customer group). Checking the console it seems like these errors could be causing the issue. It is not a browser cache issue as I have checked in Google Chrome Incognito Mode and Firefox.

Also when I’ve tried to make any change in the Magento admin to ShipperHQ and select Save Config, nothing happens. Even waiting for a few minutes, the setting never gets saved. Not sure what’s going on with the extension.

Here are the errors that appear after trying to checkout:

`TypeError: document.querySelector(...) is null shipping-service-mixin.js:93:42     addCarrierLogos website/static/version1571770231/frontend/Theme-Name/default/en_US/ShipperHQ_Shipper/js/model/shipping-service-mixin.js:93     appendSHQData website/static/version1571770231/frontend/Theme-Name/default/en_US/ShipperHQ_Shipper/js/model/shipping-service-mixin.js:141     appendSHQDataWhenLoaded website/static/version1571770231/frontend/Theme-Name/default/en_US/ShipperHQ_Shipper/js/model/shipping-service-mixin.js:150

TypeError: document.querySelector(...) is null2 shipping-service-mixin.js:93:42     addCarrierLogos website/static/version1571770231/frontend/Theme-Name/default/en_US/ShipperHQ_Shipper/js/model/shipping-service-mixin.js:93     appendSHQData website/static/version1571770231/frontend/Theme-Name/default/en_US/ShipperHQ_Shipper/js/model/shipping-service-mixin.js:141     appendSHQDataWhenLoaded website/static/version1571770231/frontend/Theme-Name/default/en_US/ShipperHQ_Shipper/js/model/shipping-service-mixin.js:150`

wsajason commented 4 years ago

Hi, The carrier logos are not currently compatible with Magento 2.3.3 but should not prevent the checkout from completing. You can disable the carrier logos via Stores > Configuration > Sales > Shipping Methods > ShipperHQ > "Hide Carrier Logos". I would recommend running the following steps:

  1. Flush the cache
  2. Remove generated file content by deleting contents of:
  1. If you are in default or production mode, you will need to recompile your code bin/magento setup:di:compile
pioneerathletics commented 4 years ago

Hi,

Thanks for replying so quickly. So the checkout problem has been corrected by clearing out those directories and re-compiling the code. I am, however, still unable to save any changes within the Magento admin for ShipperHQ. Basically anytime I hit save it just sits there and nothing happens. I’ve even tried this in Incognito mode just to make sure it wasn’t a browser cache issue.

wsajosh commented 4 years ago

Hi @pioneerathletics

If that issue is still present, can you drop us a email with your Magento admin credentials please and we can take a look for you.

One thing to check first - open up built in UPS and FedEx and when you hit save, check for JS validation errors from those modules. Sometimes, if the UPS type gets set to UPS XML in core Magento UPS, it will validate the credentials fields and not let you save if they're empty.

pioneerathletics commented 4 years ago

Hi,

Yes that was the issue. The UPS carrier was enabled, but it didn’t have any credentials in it. I disabled it and now I am able to save.

David Orzechowski

Integrated Marketing Specialist | Pioneer Athletics

800.877.1500 x3179

dorzechowski@pioneerathletics.com

From: Josh notifications@github.com Reply-To: shipperhq/module-shipper reply@reply.github.com Date: Monday, October 28, 2019 at 5:49 AM To: shipperhq/module-shipper module-shipper@noreply.github.com Cc: pioneerathletics daveo@pioneerathletics.com, Mention mention@noreply.github.com Subject: Re: [shipperhq/module-shipper] Checkout Breaks After Signing In As Customer (#72)

Hi @pioneerathletics

If that issue is still present, can you drop us a email with your Magento admin credentials please and we can take a look for you.

One thing to check first - open up built in UPS and FedEx and when you hit save, check for JS validation errors from those modules. Sometimes, if the UPS type gets set to UPS XML in core Magento UPS, it will validate the credentials fields and not let you save if they're empty.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.