search

shipperhq / module-shipper

Base ShipperHQ Repo
Open Software License 3.0
21 stars 20 forks source link

Updated shipping address renderer template with core Magento changes #89

Closed erfanimani closed 3 years ago

erfanimani commented 3 years ago

It looks like the template was copied back when Magento 2.1 was the latest version.

With this PR I've brought across the changes done since, but kept the customisations in place (destination_type and validation_status checks).

The template changes are from Magento 2.4.1, but the template still looks pretty similar to the Magento 2.2.7+ versions.

This PR fixes https://github.com/shipperhq/module-shipper/issues/87

wsagen commented 3 years ago

Thanks for the PR @erfanimani, much appreciated. The team will review next week. We are light on staff this week due to severe weather in Austin.

erfanimani commented 3 years ago

Thanks @wsagen, no problem. Best of luck to the team.

ibraheemnabeelfauzi commented 3 years ago

Hey @erfanimani many thanks for that! We're reviewing.