Class ShipperHQ\WS\PostOrder\Placeorder\Request\PlaceOrderRequestFactory does not exist

shipperhq / module-shipper

Base ShipperHQ Repo

Open Software License 3.0

21 stars 20 forks source link

Class ShipperHQ\WS\PostOrder\Placeorder\Request\PlaceOrderRequestFactory does not exist #92

Closed jerome-rakotomanga closed 3 years ago

jerome-rakotomanga commented 3 years ago

Hello,

While trying to compile (setup:di:compile in a Magento 2.3.4 website), I'm facing an error :

Class ShipperHQ\WS\PostOrder\Placeorder\Request\PlaceOrderRequestFactory does not exist

Module version : "version": "20.41.0",

Library ShipperHQ\WS is well defined in composer dependencies (require "shipperhq/library-ws": "^20.4" => using 20.4.1), but this version of library does not contain the missing class.

ibraheemnabeelfauzi commented 3 years ago

Hey @jerome-rakotomanga Please go ahead and upgrade to extension version 20.42.0 and this will be resolved. Here are the instructions on how to upgrade this: https://docs.shipperhq.com/installing-magento-2-shipperhq-extension/

msyhr commented 3 years ago

Hey @jerome-rakotomanga Please go ahead and upgrade to extension version 20.42.0 and this will be resolved. Here are the instructions on how to upgrade this: https://docs.shipperhq.com/installing-magento-2-shipperhq-extension/

This is wrong. Updating to the newest version available (M2 2.4.2) breaks compilation. See screenshot. Screenshot from 2021-03-29 23-53-13

jerome-rakotomanga commented 3 years ago

Hey @jerome-rakotomanga Please go ahead and upgrade to extension version 20.42.0 and this will be resolved. Here are the instructions on how to upgrade this: https://docs.shipperhq.com/installing-magento-2-shipperhq-extension/

Hello @ibraheemnabeelfauzi,

Unfortunately, the last release does not solve the issue : https://github.com/shipperhq/module-shipper/compare/20.41.1...20.42.0

You need :

either to update ShipperHQ\WS module to add missing Helper class
or remove references to ShipperHQ\WS\PostOrder\Placeorder\Request\PlaceOrderRequestFactory

Regards,

PS: As a quick fix, I froze the module in composer.json to the last working version "shipperhq/module-shipper": "20.40.2",

wsajosh commented 3 years ago

@jerome-rakotomanga Sincere apologies about this, I'm the developer that was working on this. Please update to 20.42.1 which should pull in library-ws to 20.5.0 which will resolve this issue

jerome-rakotomanga commented 3 years ago

Hello @wsajosh,

When running compilation (setup:di:compile) I still have an error, but a different one :

Regards,

wsajosh commented 3 years ago

@jerome-rakotomanga Thanks very much. I've updated our test plan here as clearly something went wrong. If you update to 20.42.2 it will resolve it. I've carried out the same steps as you and I'm seeing no issues now

jerome-rakotomanga commented 3 years ago

Thank you @wsajosh, last version 20.42.2 solved the issue. I haven't compilation error anymore.