search

shipperhq / module-shipper

Base ShipperHQ Repo
Open Software License 3.0
21 stars 21 forks source link

replicated a magento patch see details here https://support.magento.c… #94

Closed leedyche closed 3 years ago

leedyche commented 3 years ago

replicated a magento patch see details here https://support.magento.com/hc/en-us/articles/360058863531-MDVA-33289-Magento-patch-Javascript-in-address-at-checkout without this I get javascript displayed after the street address on the payment part of the checkout (using braintree) the link is to the magento patch for this, this change stops the patch being overwritten. Im not sure if this is needed on the shipping-information file as well, but i dont seem to get any issues without it.

I dont know if this will be usefull for anyone else, or if it should be merged in, but if you could look it over and see if its usefull

cheers

jgallup commented 3 years ago

This issue is also effecting ShipperHQ/AddressAutocomplete since it uses module-shipper as a dependency. If this is all good, can this be merged sooner rather than later?

wsadasmit commented 3 years ago

Thanks @leedyche !

We're approved this and are preparing to get it released shortly.