shipsaas / docking

DocKing: Your shared-microservice that takes over the document templates management & render/export PDF
https://docking.shipsaas.tech
MIT License
213 stars 14 forks source link

baseUrl for console seems to be hardcoded in docker image #24

Closed rshorser closed 1 year ago

rshorser commented 1 year ago

I'm trying to run docking using the latest docker image and while it runs fine, the console UI looks broken. Regardless of what I put in my env variables, it looks like the UI is referencing a baseUrl of

baseURL: "http://127.0.0.1:8888/api/v1"

and thus returns an error when I try to login:

Screen Shot 2023-09-08 at 5 51 53 PM

My best guess is that this line here is getting set at build time and then ignoring whatever the VITE_APP_URL variable is set to.

I can't tell very much how the static assets here are actually served, can the APIs just all be relative urls?

sethsandaru commented 1 year ago

Howdy @rshorser , thanks for the reporting.

And yes, you're right. docking-dev or docking-dev-octane should only be run in local/development mode. We'll always build the dev images using the fixed env variables.

It is recommended to build your own image (Docker documentation) if you wish to have specific configurations (storage, DB type, URLs, etc.)

Lemme know if you still have any concern

sethsandaru commented 1 year ago

Please feel free to open this issue again if you have more questions, have a good one 😉