shipsaw / AP-Downloader

Downloader for Armstrong Powerhouse Products
MIT License
6 stars 0 forks source link

Installing Class 90/Mk3 DVT pack downloads and installs wrong branding patch/Freightliner 90 pack doesn't download BP. #2

Open Slenderman7676 opened 1 year ago

Slenderman7676 commented 1 year ago

This is a very useful tool except tonight I bought both the Class 90/Mk3 DVT pack and the Class 90 Freightliner pack and installed them. It downloaded and installed fine except I carefully was reading the prompt during the installs and as well as looking in the folder where all files are downloaded to. I noticed two things. The installer downloaed and installed the branding patch for the Class 350 Enhancement pack instead of the correct branding patch for the 90 packs. And the installer didn't even download/install the branding patch for the Freightliner 90 pack. I assume this is an issue with the product database. I can't find any workarounds accept for having to manually download and install the correct patches from the AP website.

shipsaw commented 1 year ago

@Slenderman7676 thanks, discovered that the last DB Update had several incorrect values, I have updated the endpoint that the app uses to update the product db, after restarting AP Downloader this issue should be corrected

Slenderman7676 commented 1 year ago

Thanks. On an unrelated note. The installer doesn't seem to even know that Wherry Lines 2.0 exists. Like it is not listed at all.

shipsaw commented 1 year ago

I'll look into the wherry lines one

shipsaw commented 1 year ago

@Slenderman7676 do you have the Standalone Wherry Lines 2.0? The issue is I only have the upgrade, so don't have that info to populate the database. To add it, I would need the download link, the filename when you download it, and the image link on your downloads page. I can't actually access any of these links as I have not bought that version, but I can make it so it works for you.

Slenderman7676 commented 1 year ago

I have got the standalone 2.0.

On Wed, Feb 8, 2023 at 2:19 PM Paul Kirby @.***> wrote:

@Slenderman7676 https://github.com/Slenderman7676 do you have the Standalone Wherry Lines 2.0? The issue is I only have the upgrade, so don't have that info to populate the database. To add it, I would need the download link, the filename when you download it, and the image link on your downloads page. I can't actually access any of these links as I have not bought that version, but I can make it so it works for you.

— Reply to this email directly, view it on GitHub https://github.com/shipsaw/AP-Downloader/issues/2#issuecomment-1422671942, or unsubscribe https://github.com/notifications/unsubscribe-auth/AW33MBMEMLDO5EUBWRVNPOLWWOTPXANCNFSM6AAAAAATNA45KA . You are receiving this because you were mentioned.Message ID: @.***>

shipsaw commented 1 year ago

So because I can't get this pack as I have the Upgrade, I need the following info to add to the DB: 1) To get the download link, I need the product ID. When you go to your downloads, right click on a download link and copy-paste that to notepad etc... you should get something like: https://www.armstrongpowerhouse.com/index.php?route=account/download/download&download_id=214, the number I need in this example is 214 2) I need the name of the downloaded file, ex AP_Mk3A-B_Coach_Pack.zip 3) The link for the image in the downloads that shows the product https://www.armstrongpowerhouse.com/image/cache/catalog/APMK3A-B_Cover-238x294.png

Slenderman7676 commented 1 year ago

Okay. This should be of help.

211

AP_Wherry_Lines_Route_Pack_2.0.zip

https://www.armstrongpowerhouse.com/image/cache/catalog/APWLV2_Cover-238x294.png

shipsaw commented 1 year ago

@Slenderman7676 updated the DB, does the route show up for you now?

Slenderman7676 commented 1 year ago

@shipsaw Yes, it does. Thank you. In future perhaps it would be feasable to have a product DB megathread where users can describe current issues regarding the products DB. Like I've got another one here.

When installing either of the Class 37 Loco packs, the Branding patch is not downloaded or installed and is required to be installed manually.

Product IDs: 37 V1: 184 37 V2: 198

Relevant branding pack links: 37 V1: https://armstrongpowerhouse.com/free_download/Patches/AP_Class_37_Locomotive_Pack_Vol_1_Branding_Patch.zip 37 V2: https://armstrongpowerhouse.com/free_download/Patches/AP_Class_37_Locomotive_Pack_Vol_2_Branding_Patch.zip

shipsaw commented 1 year ago

Alright Updated the productsDB with those class 37 issues.

I'll look into the thread idea, another thing I'm trying to set up at the moment is automatic CSV generation on build or commit, so that diagnosing these DB issues will be easier for people in the future.

Thanks again for all the assistance on finding those problems

shipsaw commented 1 year ago

So I've added some hooks to generate a CSV file every time I do a commit, if you look at ApProducts.csv it will open a table with all the entries in the DB. This should make it easier to diagnose / correct issues