Closed lukemelia closed 9 years ago
This is in pretty good shape. Ready for review.
This looks good to me. I'm :+1:.
@slindberg - Thoughts?
This looks fantastic :+1:
Definitely like the beforeHook
/afterHook
naming. Thinking about it a little more, the afterCommit
/beforeTag
and afterTag
/beforePush
hooks are redundant, but it seems fine if they run in sequence just for clarity's sake. Thoughts?
Yeah, I think before/after each of those steps probably makes sense even though some will run back-to-back.
It looks like config value type mismatches are not fatal when loaded by ember-cli, but no coercion happens. I'll follow up with a quick PR to do some validation.
Thanks for all the hard work @lukemelia!
Thanks @slindberg. Props go to @chrislopresto on this too, who paired with me on it yesterday.
Very excited about this, thank you!
If you supply a function as the
beforeCommit
property in your config/release.js, it will be invoked with a reference to theproject
and theversions
object. The purpose of the hook is to allow a project to do any other updates to files that may need to be updated to the current version.e.g.