search

shipshapecode / ember-cli-release

Ember CLI addon for versioned release management
MIT License
90 stars 18 forks source link

Clarify that `v` is prefixed in `versions.next`. #29

Closed rwjblue closed 8 years ago

rwjblue commented 8 years ago

Just a small clarification to make it clear that versions.next already includes the v prefix.

Yes, this seems obvious, but for some reason I assumed otherwise initially.

slindberg commented 8 years ago

I think I might make the same mistaken assumption, even having written it all. The hooks just adopted the versions hash that was used internally, maybe these versions should be stripped of the prefix?

rwjblue commented 8 years ago

Not sure (both ways seem like they could be fine). In my mind having the version.next match the actual tag won me over...