shipshapecode / ember-cli-release

Ember CLI addon for versioned release management
MIT License
90 stars 18 forks source link

NPM Publish in release.js config not working #42

Closed offirgolan closed 8 years ago

offirgolan commented 8 years ago

Im on v1.0.0-beta.0 and this is my current config

/* jshint node:true */
/* var RSVP = require('rsvp'); */
var execSync = require('child_process').execSync;

module.exports = {
  publish: true,
  afterPublish: function(project, versions) {
    // Publish dummy app with docs to gh-pages
    runCommand('ember github-pages:commit --message "Released ' + versions.next + '"');
    runCommand('git push origin gh-pages:gh-pages');
  }
};

function runCommand(command) {
  console.log('running: ' + command);
  var output = execSync(command, { encoding: 'utf8' });
  console.log(output);
}

When I ran ember release it didnt publish or even go into the afterPublish hook.

master $> ember release
Warning: cannot specify option `publish` in config/release.js, ignoring
version: 1.13.13
Latest tag: v2.2.0
Successfully committed changes 'Released v2.2.1' locally.
[?] About to create tag 'v2.2.1' and push to remote 'origin', proceed?: Yes
Successfully created git tag 'v2.2.1' locally.
Successfully pushed 'v2.2.1' to remote 'origin'.
Successfully pushed 'master' to remote 'origin'.

Is there something im missing?

slindberg commented 8 years ago

That's a bug, fixed in #43

slindberg commented 8 years ago

Released in 1.0.0-beta.1

offirgolan commented 8 years ago

Thanks for the fix @slindberg :smile_cat:

offirgolan commented 8 years ago

1.0.0-beta.1 not on npm :cry:

slindberg commented 8 years ago

Gah, sorry about that. Published now.

offirgolan commented 8 years ago

Haha thank you!