search

shipshapecode / ember-cli-release

Ember CLI addon for versioned release management
MIT License
90 stars 18 forks source link

Remove ember deprecation warning and release as 0.2.9 #55

Closed Serabe closed 8 years ago

Serabe commented 8 years ago

Can you please apply #53 on top of version 0.2.8 and release as 0.2.9, please?

The fix is only in a 1.0.0 beta and users are complaining about a deprecation warning being there :(.

Ember-cli pins version to 0.2.9 but I can send a PR as soon as this is released.

Thank you!

rwjblue commented 8 years ago

I pushed https://github.com/lytics/ember-cli-release/tree/stable-0-2-x with the fix from #53. It is ready for releasing 0.2.9 from that branch, but I can't push to NPM.

@slindberg - If you have a minute, would you mind pushing a 0.2.9 from that branch?

slindberg commented 8 years ago

Released & published.

@rwjblue, I added you as a collaborator on NPM yesterday, did you attempt to publish and it failed?

Serabe commented 8 years ago

Thank you both!

rwjblue commented 8 years ago

@slindberg - I didn't try, but I did run 'npm owners ls ember-cli-release' and didn't think it showed me, but I could be wrong.

Thanks again for publishing!

slindberg commented 8 years ago

@rwjblue I don't know what the difference between a contributor and owner is, but you are an owner now too 😉