search

shipshapecode / ember-cli-release

Ember CLI addon for versioned release management
MIT License
90 stars 18 forks source link

Fail on push with pre-push hook #56

Open vvscode opened 8 years ago

vvscode commented 8 years ago

We have pre-push hook, which run tests before push. With regular push all works fine, but with ember release I got errors like

Latest version: v5.41.8
Successfully committed changes 'Released v5.41.9' locally.
[?] About to create tag 'v5.41.9' and push to remote 'origin', proceed?: Yes
Successfully created git tag 'v5.41.9' locally.
error: failed to push some refs to 'git@github.com:collectrium/apollo.git'

Error: error: failed to push some refs to 'git@github.com:collectrium/apollo.git'

    at ChildProcess.<anonymous> (/Users/vvs/repo/apollo/node_modules/ember-cli-release/node_modules/git-tools/node_modules/spawnback/index.js:31:12)
    at emitTwo (events.js:87:13)
    at ChildProcess.emit (events.js:172:7)
    at maybeClose (internal/child_process.js:817:16)
    at Socket.<anonymous> (internal/child_process.js:319:11)
    at emitOne (events.js:77:13)
    at Socket.emit (events.js:169:7)
    at Pipe._onclose (net.js:469:12)

After that I should push all manually. Can we add option to pass params into git push ? ( I mean --no-verify on pushing tag )?