search

shipshapecode / ember-cli-release

Ember CLI addon for versioned release management
MIT License
90 stars 18 forks source link

Using old npm forces old node-gyp -> makes windows build problems #63

Open jacobq opened 7 years ago

jacobq commented 7 years ago

Could you please upgrade / loosen the dependency on npm v3.5.x?

I was having an awful time trying to figure out why I was having a build problem regarding redefinition of __pfnDliNotifyHook2 in win_delay_load_hook.c (part of node-gyp) then I was told it was caused by a node-gyp bug that was fixed like a year ago. Since I had a newer version of node-gyp and npm installed I couldn't figure out why it was happening. It turns out it was caused by ember-cli-release since it pins its npm version to 3.5.x, which pins node-gyp to 3.2.x, which causes pain. See https://github.com/nodejs/node-gyp/issues/972#issuecomment-310420222