search

shipshapecode / ember-cli-release

Ember CLI addon for versioned release management
MIT License
90 stars 18 forks source link

Hook to update versions of additional files? #8

Closed lukemelia closed 9 years ago

lukemelia commented 9 years ago

We're working on a cordova app that has has android and ios files with version numbers in addition to package.json and bower.json. Would you be open to a PR that allows apps to configure a hook that will be run by ember-cli-release when a new version number is being applied to manifest files?

slindberg commented 9 years ago

Yes! Hooks are great :+1:

Making the list of manifest files configurable has been on my TODO list for while, would that be sufficient for your purposes, or do you need to make custom edits to those files at the same time? BTW, I'm usually on ember slack and freenode if you'd like to DM me.

rwjblue commented 9 years ago

I would also love a hook (and to have the list of manifest files configurable).

lukemelia commented 9 years ago

@slindberg I think a hook is going to be more flexible because not all manifest files will be JSON with a version key.

rwjblue commented 9 years ago

Would it be feasible to have the hooks default implementation be the current JSON manifest 'version' bump? Or should they be kept separate?

lukemelia commented 9 years ago

I'm inclined to keep them separate.

I pushed an implementation. See #12

slindberg commented 9 years ago

Hooks released in v0.2.4.