search

shipshapecode / ember-prism

Easy ember components for syntax highlighting a-la PrismJS
MIT License
35 stars 26 forks source link

Convert to TypeScript #878

Closed charlesfries closed 7 months ago

charlesfries commented 10 months ago
RobbieTheWagner commented 7 months ago

Thanks for the PR @charlesfries! Would you be interested in finishing it up or would you like some help?

charlesfries commented 7 months ago

Thanks @RobbieTheWagner, it should be good now. The only minor annoyance is the usage of declare const Prism: any;; I tried installing @types/prismjs and then importing Prism from prismjs but that seems to slightly change the padding of the code blocks on the test app.

Not sure what the deal is there but I just left the globals in and added that line.

RobbieTheWagner commented 7 months ago

LGTM, thanks for the PR!