search

shipshapecode / shepherd

Guide your users through a tour of your app
https://shepherdjs.dev
Other
13.05k stars 646 forks source link

classPrefix breaks target blocking #1298

Open npedrini opened 3 years ago

npedrini commented 3 years ago

If you specify a classPrefix in the tour options, any highlighted elements in steps where canClickTarget = true are still clickable because the following css selector breaks:

.shepherd-target-click-disabled.shepherd-enabled.shepherd-target,.shepherd-target-click-disabled.shepherd-enabled.shepherd-target *{
    pointer-events:none
}

The following custom css rule has to be added, taking into account the classPrefix:

.shepherd-target-click-disabled.walkthrough-shepherd-enabled.shepherd-target,.shepherd-target-click-disabled.walkthrough-shepherd-enabled.shepherd-target *{
    pointer-events:none
}
RobbieTheWagner commented 3 years ago

@npedrini would you like to submit a PR adding class prefix support for this?

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

edenriquez commented 3 years ago

Is this issue still happening ? can I take it ?

RobbieTheWagner commented 3 years ago

@edenriquez sure thing, please feel free to take it!

arrfandannge commented 5 months ago

Assuming that this issue is still reproducing since its marked open. Can i take it?

RobbieTheWagner commented 5 months ago

@arrfandannge I am honestly not sure, but please feel free to investigate and take on the work if you would like!