shipshapecode / shepherd

Guide your users through a tour of your app
https://shepherdjs.dev
Other
13.03k stars 647 forks source link

Pinch zooming gestures breaking overlay on Android (Brave) and iPad (Safari) #2495

Open nathnolt opened 1 year ago

nathnolt commented 1 year ago

Version: 11.2.0 Devices: iPad (iOs safari), Android (on Brave)

Pinch zooming on touch devices are causing problems with the overlay, where the overlay rectangle stays locked to the top left of the layout viewport (this is the main problem), and is the size of the visualviewport (this is fine). But because the overlay is not moving, part of the document does not have the overlay, which allows you to interact with this part of the document (despite it disallowing pinch and pan gestures), plus the overlay looks weird.

on desktop devices, when you change the zoom level (by doing ctrl+scrolling) the overlay seems to fix itself, but this process does not seem to happen on these touch devices.

This happens on https://shepherdjs.dev/ as well.

On a Chromebook, pinch zooming seemingly works correctly.

slef commented 6 months ago

+1 I see the same issue on iPhone