shipt / segmented-arc-for-react-native

Segmented arc component for React Native
MIT License
93 stars 10 forks source link

generate-example-app #14

Closed ChiefoftheOwls closed 2 years ago

ChiefoftheOwls commented 2 years ago

A working generated app.

Will work on more examples.

edit: updated screenshots to reflect data in the center

Simulator Screen Shot - iPhone 12 - 2021-12-16 at 09 27 27

Simulator Screen Shot - iPhone 12 - 2021-12-16 at 09 27 42

codecov[bot] commented 2 years ago

Codecov Report

Merging #14 (b92b086) into development (6ae1426) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development      #14   +/-   ##
============================================
  Coverage        89.40%   89.40%           
============================================
  Files                5        5           
  Lines              151      151           
  Branches            48       48           
============================================
  Hits               135      135           
  Misses              16       16           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6ae1426...b92b086. Read the comment docs.

jkhusanov commented 2 years ago

Also, @ChiefoftheOwls could you fix this here: https://github.com/shipt/react-native-segmented-arc/blob/fcdb9a9784cc2ad1ac9e8fcadbda50210ec355c3/example/App.js#L54

metaData.lastFilledSegment.label to metaData.lastFilledSegment.data.label

It's for rendering additional data in the middle of the component. Currently, it's missing because of that.

MarquessV commented 2 years ago

Why nest exampleApp inside of example? Can we just put all this in the example directory?

jkhusanov commented 2 years ago

@MarquessV done. I've moved everything under example