search

shiptest-ss13 / Shiptest

The Shiptest Codebase
https://shiptest.net
GNU Affero General Public License v3.0
95 stars 485 forks source link

[BUG] Opening drying rack tgui forcebly #1192

Open Sweettoothart opened 2 years ago

Sweettoothart commented 2 years ago

Issue reported from Round ID: 916 (Shiptest)

Reporting client version: 514.1583

Step one, have a drying rack. Step two, have a plant bag (with plants inside). Have a person stand next to the drying rack, and deposit the plants. The person standing next to it should have the tgui popup

IndusRobot commented 2 years ago

I've tracked down the behavior to this line: https://github.com/shiptest-ss13/Shiptest/blob/24c5bdde605104c1ef28bd882a455f6844e7211e/code/game/objects/objs.dm#L154

TGUI machines update the mob's machine var which stores the last machine they interacted with. Then it runs a separate updateUsrDialog which basically does a fuzzy search on all nearby mobs whose machine var matches, rather than directly updating the mob's view who actually used the machine.

Touching this code may have unexpected behavior.