search

shiptest-ss13 / Shiptest

The Shiptest Codebase
https://shiptest.net
GNU Affero General Public License v3.0
109 stars 530 forks source link

Ammo Antics #3694

Closed Erikafox closed 1 week ago

Erikafox commented 4 weeks ago

About The Pull Request

Subtypes AP/HP/Rubber ammo for several calibres that didn't have it. adds it to the market in relevant cases. adds tracker rounds to a few places. makes them work differently. removes incendiary ammo from everything except shotguns

Why It's Good For The Game

makes the ammo gameplay stuff available to more weapons. entertainment value

Changelog

:cl: add: rifle calibre and pdw calibre rubbershot/armor piercing/hollow point. check da outpost add: tracker rounds for a few guns. check the black market :3 del: most forms of incendiary ammo del: A bunch of clown and mime stuff tangentially related to guns

/:cl:

github-actions[bot] commented 3 weeks ago

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] commented 3 weeks ago

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Apogee-dev commented 3 weeks ago

I wonder how viable it would be to make the speed values you defined here modifiers on the cartridge’s base speed value rather than fixed values? I was looking over the code and noticed a few weird things here and there like match revolver bullets being faster than standard DMR bullets. it’d be nice if we could make certain guns in general have slightly faster or slower bullets than others while still having the cleaner, lower-maintenance code you made here for the cartridges

Erikafox commented 3 weeks ago

I wonder how viable it would be to make the speed values you defined here modifiers on the cartridge’s base speed value rather than fixed values? I was looking over the code and noticed a few weird things here and there like match revolver bullets being faster than standard DMR bullets. it’d be nice if we could make certain guns in general have slightly faster or slower bullets than others.

we'd have to tie it to a modifier like how bullet skins work. not opposed to doing it like such, though.

generalthrax commented 3 weeks ago

A few select bullet types like .22lr hollow / rubber and .300 are half and half normal. Probably a quick fix but something you might wanna look at before We Become Real

github-actions[bot] commented 2 weeks ago

This pull request has conflicts, please resolve those before we can evaluate the pull request.

generalthrax commented 2 weeks ago

6.5x57mm only has half the ammo and its the wrong ammo type for both normal and trackers.

github-actions[bot] commented 1 week ago

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Erikafox commented 1 week ago

yaaaaay