shiptest-ss13 / Shiptest

The Shiptest Codebase
https://shiptest.net
GNU Affero General Public License v3.0
109 stars 530 forks source link

Factional Cargo, done in a day #3758

Open rye-rice opened 1 week ago

rye-rice commented 1 week ago

About The Pull Request

Split off from Overmap Expansion # 5

This was done in a day.

Yes. This Thing that has been anticipated for 2-3 years was done in a day.

How did I even accomplish this?

While attempting to unhardcode cargo/clean up outpost code, I noticed that factional cargo was actually really easy to do. So I did it. If I really wanted to be fancy, I could take 12 months to code cargo from scratch. But this was easier. So I did it.

huge thanks to @firebudgy for coding support and adding more stuff to factional cargo instead of this just being a bare framework

Why It's Good For The Game

November 12 2024 462 November 12 2024 461 November 12 2024 460

Changelog

:cl: rye-rice, firebudgy add: Factional cargo. del: the remminants of the P16 as it was already completely removed in Serene Sporting balance: Sporter is now 400 credits. /:cl:

Martinpachu commented 1 week ago

hellow should the egun lasgun and mini egun have a discount for nt since theyre sharplite. thanks and have fun

Apogee-dev commented 1 week ago

for magazines, remember to offer the smallest size. stuff like the 6 round box mags for the bulldog & mastiff for both syndies & inteq

firebudgy commented 6 days ago

for magazines, remember to offer the smallest size. stuff like the 6 round box mags for the bulldog & mastiff for both syndies & inteq

All of these are the smallest sizes as appropriate for their respective guns. Already covered my bases.

randy10122 commented 2 days ago

through the time this was testmerged, it didnt break anything - why hasnt it been merged yet? even if there ends up being a handful of things missing, itd be almost comedically easy to add on in further prs