search

shiptest-ss13 / Shiptest

The Shiptest Codebase
https://shiptest.net
GNU Affero General Public License v3.0
109 stars 530 forks source link

Removes marine armor from cargo #3789

Open rye-rice opened 1 week ago

rye-rice commented 1 week ago

About The Pull Request

Removes marine armor from cargo and reverts the nerfs

Why It's Good For The Game

For the record, i'm not against limb armor at all or even the niche of marine armor in cargo, I just do not like the sprite and it I especially don't like seeing people with it, for aesthetics and gameplay reasons

I do like the idea of the marine armor. Just moving the marine into cargo instead of making a new, well balanced and sprited armor doesn't help

This isn't a kneejerk revert, I've been watching the past 3 uptimes closely.

It being the "meta" for the past week of uptime doesn't do much favors. I understand there's a price increase, but I suspsect it will still be the "goal" even if it costs a hundred thousand credits per unit

While I could just make it so no indies can aquire it with the factional cargo PR, I still liked the visual diversity of factions before this armor was added.

If you (assuming you are a dev or a maint) want a replacement please to merge this please ask me and ill see if I can draw/make one, for now I think this is for the best.

If you still want more time to test the marine armor experiment, i'm willing to wait a week for it

Changelog

:cl: del: Marine armor from cargo. ERTs may still aquire it /:cl:

Erikafox commented 1 week ago

I do think 2 uptimes isn't exactly the 'past week' (or a good dataset). it's been the shiny new thing for both those uptimes and that throws off perceptions.

rye-rice commented 1 week ago

thats fair, want me to wait another week then?

thgvr commented 1 week ago

If your main reason here is not liking the sprite, this is not gonna get merged

tzui5020 commented 1 week ago

I think every faction having their own set of full limb heavy armor that is expensive would be very cool and Marine armor could be that niche for indies and I'm just spitballing here maybe for the gorlex gang (NGR, hardliners, Ramzi) it could be their hardsuit , Inteq could have marine armor with a yellow visor and other accessories and so on and so forth.

thgvr commented 1 week ago

You can remove just the helmet actually, that one's not good.

firebudgy commented 1 week ago

After some testing and experimentation, this armor (particularly medium armor available for 2000 credits) has higher damage resistances than factional blood-red armor suits which are generally either ERT or spawns on ships that cannot be replaced. Ideally this should either have it's armor values reduced to compensate or the price significantly increased, as at the moment this is... far too protective for something you can get in 30 minutes of time.

MassiveMen commented 1 week ago

Even if this isnt removed, it needs a significant price hike. A better blood red with no slowdown shouldnt be two thousand.

github-actions[bot] commented 6 days ago

This pull request has conflicts, please resolve those before we can evaluate the pull request.