shipwright-io / build

Shipwright - a framework for building container images on Kubernetes
https://shipwright.io
Apache License 2.0
654 stars 111 forks source link

Add StepOutOfMemory as reason for BuildRun failure #1588

Closed SaschaSchwarze0 closed 5 months ago

SaschaSchwarze0 commented 5 months ago

Changes

When a BuildRun Pod fails because of too much ephemeral storage usage and is therefore evicted, then we expose this nicely in the BuildRun status as the condition reason is set to PodEvicted. In case a container went out of memory, we did not expose that at all in the BuildRun status while it is quite obvious in the TaskRun and Pod status who print the step/container status.

I am therefore proposing here to introduce the BuildRun failure reason StepOutOfMemory.

Submitter Checklist

Release Notes

You can now easily determine that your BuildRun failed because a step went out of memory as the reason is now set to StepOutOfMemory
openshift-ci[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qu1queee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/shipwright-io/build/blob/main/OWNERS)~~ [qu1queee] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
qu1queee commented 5 months ago

/lgtm