[BUG] Automatic release README update needs to be fixed

shipwright-io / build

Shipwright - a framework for building container images on Kubernetes

https://shipwright.io

Apache License 2.0

626 stars 107 forks source link

[BUG] Automatic release README update needs to be fixed #1601

Closed SaschaSchwarze0 closed 2 weeks ago

SaschaSchwarze0 commented 1 month ago

Is there an existing issue for this?

[X] I have searched the existing issues

Kubernetes Version

No response

Shipwright Version

No response

Current Behavior

See https://github.com/shipwright-io/build/pull/1562#pullrequestreview-2053469134. We need to fix the README manually, and fix the automation to also bump the additional place (and more ?).

Expected Behavior

No response

Steps To Reproduce

No response

Anything else?

No response

SaschaSchwarze0 commented 1 month ago

@adambkaplan you mentioned "a few" spots. If you know of more already, pls post them here. Tyia.

qu1queee commented 1 month ago

@adambkaplan to provide more insights on the details for fixing this one.

Redeltaz commented 1 month ago

I think maybe it's about the curl line inside the README.md file, which was added on this commit. This line also display the release tag, but is not included inside the workfow that update all the tags of the README doc with the new version. So the curl line doesn't get updated by the workflow, which I suppose is the "few spots" mentionned by @adambkaplan.

The workflow only update the https://github.com/shipwright-io/build/.... URL, but the curl line use a https://raw.githubusercontent.com/shipwright-io/build/... which is not included inside the workflow as I said

I'm interested to work on this issue if it's possible and if my deductions are correct :)

qu1queee commented 1 month ago

@Redeltaz thanks for the interest, please go ahead, if something needs to be change we can discuss that on your PR. By the way, we have a slack channel as well, to get in contact with folks faster, see here