shipwright-io / build

Shipwright - a framework for building container images on Kubernetes

https://shipwright.io

Apache License 2.0

626 stars 107 forks source link

Updates to Owners #1608

Closed qu1queee closed 3 weeks ago

qu1queee commented 1 month ago

Changes

Move out @otaviof to Emeritus Add @apoorvajagtap to approvers and reviewers. Add @karanibm6 to approvers

Congrats @apoorvajagtap and @karanibm6 !

Submitter Checklist

[ ] Includes tests if functionality changed/was added
[ ] Includes docs if changes are user-facing
[x] Set a kind label on this PR
[x] Release notes block has been filled in, or marked NONE

See the contributor guide for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

NONE

HeavyWombat commented 1 month ago

Do we have any documentation on the emeritus_ prefix? I cannot find anything in https://www.kubernetes.dev/docs/guide/owners/ other than emeritus_approvers.

qu1queee commented 1 month ago

@HeavyWombat this follows what we have in CLI, it does not affect anything. If we stick to the guidelines then what we need to do is simply remove reviewers, per:

If the person is in reviewers section, their GitHub id will be removed from the section

I prefer to have the reviewers emeritus.

SaschaSchwarze0 commented 1 month ago

@HeavyWombat this follows what we have in CLI, it does not affect anything. If we stick to the guidelines then what we need to do is simply remove reviewers, per:

If the person is in reviewers section, their GitHub id will be removed from the section

I prefer to have the reviewers emeritus.

I think we need to doublecheck at least.

I remember a discussion in a community meeting where we had the same and I think @adambkaplan clarified that unfortunatly, there are no emeritus reviewers. Should the (unknown) field be ignored by whatever tool that is reading this file, then fine with me. But we should rule out that it breaks something.

qu1queee commented 3 weeks ago

I removed the emeritus_reviewer, can I get a review pls @SaschaSchwarze0 @adambkaplan ?

openshift-ci[bot] commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HeavyWombat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/shipwright-io/build/blob/main/OWNERS)~~ [HeavyWombat] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment