shipwright-io / build

Shipwright - a framework for building container images on Kubernetes
https://shipwright.io
Apache License 2.0
645 stars 110 forks source link

Refactor/simplify test asset directory look-up #1620

Closed HeavyWombat closed 3 months ago

HeavyWombat commented 3 months ago

Changes

Simplify the look-up for the test asset directory. No need for path cleaning function since it is a test case and the look-up is relative by default, so there is no need to look-up the current working directory.

Submitter Checklist

See the contributor guide for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

NONE
openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SaschaSchwarze0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/shipwright-io/build/blob/main/OWNERS)~~ [SaschaSchwarze0] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment