search

shipwright-io / build

Shipwright - a framework for building container images on Kubernetes
https://shipwright.io
Apache License 2.0
636 stars 109 forks source link

Pin to newer Node version that is still supported by Paketo #1645

Closed SaschaSchwarze0 closed 1 month ago

SaschaSchwarze0 commented 1 month ago

Changes

https://github.com/shipwright-io/sample-nodejs/pull/12 updated the node version in our sample to 18 because Paketo removed support for Node 16. Though, the e2e test case for image mutation is using a specific commit of that repository to be able to test that the source timestamp is correct.

To fix this, I am changing the configuration of the Build to use an environment variable that tells Paketo to use Node 20.

Submitter Checklist

Release Notes

NONE
karanibm6 commented 1 month ago

/approve

SaschaSchwarze0 commented 1 month ago

/approve

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: karanibm6, SaschaSchwarze0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/shipwright-io/build/blob/main/OWNERS)~~ [SaschaSchwarze0] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment