search

shipwright-io / build

Shipwright - a framework for building container images on Kubernetes
https://shipwright.io
Apache License 2.0
628 stars 107 forks source link

Add Copyright information in all codes #336

Closed zhangtbj closed 3 years ago

zhangtbj commented 3 years ago

We should also follow the official open-source way to add the CopyRight information for our all codes, like: https://github.com/knative/serving/blob/master/pkg/reconciler/autoscaling/hpa/controller.go#L1-L15

By using our Apache license: https://github.com/redhat-developer/build/blob/master/LICENSE

Like this:

/*
Copyright 2020 The Build Authors

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

    http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
zhangtbj commented 3 years ago

Let us confirm in today's meeting.

If all agree, we will add it for all codes for the legal process.

qu1queee commented 3 years ago

+1

sbose78 commented 3 years ago

@adambkaplan is working on resolving this.

qu1queee commented 3 years ago

@adambkaplan any updates?

adambkaplan commented 3 years ago

I am waiting to hear back from Red Hat's Open Source Program Office with guidance on proper copyright notice. I will update this issue once I receive their response.

qu1queee commented 3 years ago

@adambkaplan any updates :) ?

sbose78 commented 3 years ago

Is there a specific urgency that we need to be aware of?

qu1queee commented 3 years ago

@sbose78 none, just trying to avoid stale issues now that we are "live" and trying to get some updates. No pressure intended

sbose78 commented 3 years ago

Thanks you ! That helps!

I'll ensure we continue doing follow-ups to get to a conclusion.

adambkaplan commented 3 years ago

Red Hat's OSPO recommended the following:

  1. Use "Authors" or "Contributors" instead of "Mantainers" - the latter is too restrictive, whereas "Authors" or "Contributors" covers everyone who submits code.
  2. Don't include a date in the copyright notice - this is the current recommendation of the Linux Foundation.
  3. Include a notice on all files - BUT we can replace the Apache boilerplate notice with the SPDX-License-Identifier [1]. The Linux Foundation considers this an acceptable substitute for the notice, with the added benefit that the license notice is machine-readable as well as human readable.

I propose the following notice:

/*
Copyright The Shipwright Contributors

SPDX-License-Identifier: Apache-2.0
*/

[1] https://spdx.dev/ids/