shipwright-io / build

Shipwright - a framework for building container images on Kubernetes
https://shipwright.io
Apache License 2.0
659 stars 113 forks source link

BuildRun reconciliation sets status on parent Build object #827

Open adambkaplan opened 3 years ago

adambkaplan commented 3 years ago

If a BuildRun's parent Build object has the BuildRun deletion annotation, the reconciliation of a BuildRun can cause the parent Build object to have the status SetOwnerReferenceFailed. This pollutes the status of the Build object, since its top-level status includes information set by individual child objects.

If the BuildRun reconciler can't set the owner reference on a BuildRun object, this error should be reported in the status of the BuildRun object.

See https://github.com/shipwright-io/build/pull/824/files#r659178157

/kind bug

sbose78 commented 3 years ago

Discussion in the grooming: