search

shipwright-io / build

Shipwright - a framework for building container images on Kubernetes
https://shipwright.io
Apache License 2.0
645 stars 110 forks source link

Translate `test/data` YAML files into in-code specs #866

Open HeavyWombat opened 3 years ago

HeavyWombat commented 3 years ago

With the bundle end to end tests, a prototype style build and buildrun spec definition was introduced: https://github.com/shipwright-io/build/blob/main/test/e2e/e2e_bundle_test.go#L60-L69

Migrate the existing YAML files in test/data into the prototype definitions so that the actual test code and the spec are done in the same place. This should also reduce the overall amount of YAML files in the repository.

adambkaplan commented 3 years ago

Accepting this into the general backlog. Marking this as a good first issue for new contributors.

coreydaley commented 2 years ago

/assign @aryaman02

openshift-ci[bot] commented 2 years ago

@coreydaley: GitHub didn't allow me to assign the following users: aryaman02.

Note that only shipwright-io members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide

In response to [this](https://github.com/shipwright-io/build/issues/866#issuecomment-1188154400): >/assign @aryaman02 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
coreydaley commented 2 years ago

/assign @aryaman02