Write missing E2E test for Git URL rewrite feature

HeavyWombat commented 2 years ago

The Git URL rewrite feature is only covered by unit tests. However, the build controller is using the Git step and can set the flag for enabling Git URL rewriting so this needs to be tested in an E2E test as well.

The setup is as follows:

Controller logic for Git URL rewrite is disabled by default through an environment variable.
In case it is set to "true", the controller will add an additional flag to the Git wrapper binary.
This will trigger additional code to be executed in the Git wrapper.

Idea: Use the HTTPS URL used in the unit test and build an E2E test around it with: Git URL rewrite enabled, HTTPS URL used as a source pointing to a private repository and a private key being specified.

adambkaplan commented 2 years ago

/kind cleanup

adambkaplan commented 2 years ago

Our current test framework doesn't have a mechanism that lets us update the build controller's configuration and roll out a new deployment. Tests with extra configurations also need to run serially so that the new configuration doesn't conflict with other features/tests.

Ginkgo v2 has first-class support for this: https://onsi.github.io/ginkgo/MIGRATING_TO_V2

qu1queee commented 2 years ago

From grooming, keeping this one here for more feedback. There seems to be a dependency here with https://github.com/shipwright-io/build/issues/874 . So we should prioritize on https://github.com/shipwright-io/build/issues/874.

shipwright-io / build

Write missing E2E test for Git URL rewrite feature #954