shipwright-io / community

Community documentation for Shipwright

Apache License 2.0

16 stars 15 forks source link

Update output timestamp SHIP #187

Closed HeavyWombat closed 6 months ago

HeavyWombat commented 7 months ago

Changes

Add missing BuildTimestamp in example.

Submitter Checklist

[ ] Includes tests if functionality changed/was added
[ ] Includes docs if changes are user-facing
[X] Set a kind label on this PR
[X] Release notes block has been filled in, or marked NONE

See the contributor guide for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

NONE

HeavyWombat commented 7 months ago

/kind cleanup

qu1queee commented 7 months ago

@HeavyWombat can you move this one to implemented? then we can merge this once, once your other PR in Build is merged.

qu1queee commented 7 months ago

@HeavyWombat I think we can merge this, PR looks good.

openshift-ci[bot] commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qu1queee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/shipwright-io/community/blob/main/OWNERS)~~ [qu1queee] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment