shipwright-io / operator

An operator to install and configure Shipwright Builds on Kubernetes clusters.

Apache License 2.0

19 stars 17 forks source link

Operator should not delete CRDs #172

Closed jkhelil closed 11 months ago

jkhelil commented 11 months ago

Changes

Filter Crds before deleting resources because operator should not delete Crds when shipwright instance is deleted

Fixes #173

Submitter Checklist

[x] Includes tests if functionality changed/was added
[ ] Includes docs if changes are user-facing
[x] Set a kind label on this PR
[x] Release notes block has been filled in, or marked NONE

See the contributor guide for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

Shipwright's Build CRDs are no longer deleted when the `ShipwrightBuild` object is deleted.

adambkaplan commented 11 months ago

/kind bug

openshift-ci[bot] commented 11 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/shipwright-io/operator/blob/main/OWNERS)~~ [adambkaplan] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

adambkaplan commented 11 months ago

/lgtm

I am going to merge this as-is. Any additional work regarding test setup/teardown can be addressed in a follow-up pull request.

adambkaplan commented 11 months ago

Fixes #174