search

shipwright-io / operator

An operator to install and configure Shipwright Builds on Kubernetes clusters.
Apache License 2.0
19 stars 17 forks source link

[FEATURE] Handle deletion of roles for webhook deployment #181

Closed SaschaSchwarze0 closed 3 months ago

SaschaSchwarze0 commented 8 months ago

Is there an existing feature request for this?

Is your feature request related to a problem or use-case? Please describe.

We shipped Shipwright Build v0.12.0 with a cluster role and a binding for the webhook that are unnecessary. To follow least-privilege principle, we removed them in https://github.com/shipwright-io/build/pull/1448.

The operator must handle the deletion.

Describe the solution that you would like.

When updating v0.13.0, the operator should delete the clusterrole shipwright-build-webhook and the clusterrolebinding shipwright-build-webhook.

Describe alternatives you have considered.

No response

Anything else?

No response

adambkaplan commented 3 months ago

/close

Fixed in #214

openshift-ci[bot] commented 3 months ago

@adambkaplan: Closing this issue.

In response to [this](https://github.com/shipwright-io/operator/issues/181#issuecomment-2165837145): >/close > >Fixed in #214 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.