shipwright-io / operator

An operator to install and configure Shipwright Builds on Kubernetes clusters.
Apache License 2.0
19 stars 17 forks source link

[BUG] v0.12.0 does not ship an exact match of build v0.12.0 #184

Closed adambkaplan closed 4 months ago

adambkaplan commented 8 months ago

Is there an existing issue for this?

Kubernetes Version

1.26

Shipwright Version

v0.12.0

Current Behavior

The release.yaml manifest in kodata does not match what is published on the corresponding GitHub release. This makes it challenging to identify future updates to the release manifest.

Expected Behavior

release.yaml for the operator should closely match release.yaml published on GitHub.

Steps To Reproduce

No response

Anything else?

When attempting to update release.yaml so that it aligns with the published version, unit and e2e tests fail. See #182

adambkaplan commented 5 months ago

Root causes of this issue:

For v0.12.0, this was fixed by manually crafting a release.yaml that removed the description fields from our CRDs (which can be quite lengthy).

Until manfiestival supports server-side apply, we can work around this by adding a Transform function that truncates the description fields in the CRDs.

adambkaplan commented 5 months ago

This issue is going to block #181 (or we need to craft a release.yaml which strips out the descriptions of CRD fields).

qu1queee commented 5 months ago

From refinement, where are we with this one @adambkaplan .

adambkaplan commented 4 months ago

Updated status - we merged #204 which should unblock us from using the release.yaml from the v0.12.0 release.

Alternatively, we use the v0.13.0 release candidate manifest, thereby allowing us to work on #181 (at the same time?)