shipwright-io / operator

An operator to install and configure Shipwright Builds on Kubernetes clusters.

Apache License 2.0

19 stars 17 forks source link

Use build release #188

Closed jkhelil closed 3 months ago

jkhelil commented 7 months ago

Changes

Use release.yaml from build github release
Replace manifestival/controller-runtime-client with manifestival/client-go-client

Fixes https://github.com/shipwright-io/operator/issues/184

Submitter Checklist

[ ] Includes tests if functionality changed/was added
[ ] Includes docs if changes are user-facing
[ ] Set a kind label on this PR
[ ] Release notes block has been filled in, or marked NONE

See the contributor guide for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

None

openshift-ci[bot] commented 7 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from jkhelil. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/shipwright-io/operator/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

jkhelil commented 7 months ago

@adambkaplan I am tryijng to move from manifestival/controller-runtie-cient to maifestival/client-go-client, hoping it handling the server side apply hiweer the tests are not working unfortenately on envtest. Do you have any idea why envtest is not initlialzing with client-go?

adambkaplan commented 7 months ago

I would imagine that this PR will need more work replacing instances of the controller-runtime client with the plain k8s client, which would have far-reaching consequences.

Per @joelanford - it sounds like we can use the controller-runtime Patch method and send it unstructured JSON, which would then let us do server-side apply. If we take this approach, we'd want to contribute the change to Manifestival.

We may also want to take this as a moment to reconsider the manfiestival-based approach in the operator. Tekton and ArgoCD's operators both share the challenge of deploying their own "child" CRDs - what are they doing?

cc @vdemeester @janfis

qu1queee commented 3 months ago

From Refinement, nothing to do here, and it might be fixed by another PR.