search

shipwright-io / operator

An operator to install and configure Shipwright Builds on Kubernetes clusters.
Apache License 2.0
19 stars 17 forks source link

Source release.yaml from GitHub release #208

Closed ayushsatyam146 closed 4 months ago

ayushsatyam146 commented 4 months ago

Changes

The release.yaml used as the base for deploying Shipwright Builds appears to have been manipulated by a YAML linter or other processor. There are significant differentes in YAML structure and formatting between the kodata/release.yaml in tree and the release.yaml published on GitHub for the respective release (v0.12.0). This makes it difficult to verify that the operator is deploying the right thing, especially when versions are bumped.

This replaces the kodata/release.yaml in tree with the release.yaml published for v0.12.0. This will make it easy to verify that we are deploying the right version of Shipwright Builds with the operator, as well as support future workflows that let contributors update the deployed operand from a nightly release.

Fixes #184

Submitter Checklist

See the contributor guide for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

NONE
openshift-ci[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign heavywombat for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/shipwright-io/operator/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
adambkaplan commented 4 months ago

@ayushsatyam146 Is this the same/exact content as #182 (just rebased?). I updated my original PR - with an additional commit that addressed an RBAC issue.