shipwright-io / operator

An operator to install and configure Shipwright Builds on Kubernetes clusters.

Apache License 2.0

19 stars 17 forks source link

Parse Build Strategies with Manifestival #215

Closed adambkaplan closed 4 months ago

adambkaplan commented 4 months ago

Changes

Use manifestival to parse the build strategies in the sample buildstrategies directory. This will make it easier for tests to decode YAML data for build strategies.

/kind cleanup

Submitter Checklist

[x] Includes tests if functionality changed/was added
[ ] Includes docs if changes are user-facing
[x] Set a kind label on this PR
[x] Release notes block has been filled in, or marked NONE

See the contributor guide for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

NONE

adambkaplan commented 4 months ago

/approve

Self-approving - we should have used Manifestval for this all along.

openshift-ci[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/shipwright-io/operator/blob/main/OWNERS)~~ [adambkaplan] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

ayushsatyam146 commented 4 months ago

/lgtm