search

shipwright-io / triggers

Event-driven Shipwright Builds
Apache License 2.0
6 stars 7 forks source link

Add support for Tekton's beta CustomRun #24

Closed SaschaSchwarze0 closed 1 year ago

SaschaSchwarze0 commented 1 year ago

We support so far Tekton's alpha Run. In the meantime, Tekton also has a beta version called CustomRun. A feature flag on Tekton controls which of the two CRDs are used by Tekton. Since v0.44.0, the beta CustomRun is default. Reference: https://github.com/tektoncd/pipeline/blob/v0.44.0/config/config-feature-flags.yaml#L96

We should provide conditional support based on the availability of the custom resource definition.

otaviof commented 1 year ago

We might need to watch for both objects in the controller, also make sure the golang "vendoring" is reflecting what we need.

SaschaSchwarze0 commented 1 year ago

We might need to watch for both objects in the controller, also make sure the golang "vendoring" is reflecting what we need.

+1 I think the CustomRun does not exist in Tekton v0.38 yet = we need a bump of the Tekton version. And if we do that as usual, then we would do that in the Build repo and then pick up that change in Triggers.