shipwright-io / triggers

Event-driven Shipwright Builds
Apache License 2.0
6 stars 7 forks source link

Add results to custom task support #25

Open SaschaSchwarze0 opened 1 year ago

SaschaSchwarze0 commented 1 year ago

When a Shipwright Build runs as part of a larger pipeline, then this pipeline may want to perform further steps after the BuildRun succeeded. For this, it needs access to image details, in particular the digest. We should pass it (maybe together with other image details) as result of the custom task to the pipeline.

Tekton docs: https://tekton.dev/docs/pipelines/customruns/#monitoring-results

SaschaSchwarze0 commented 1 year ago

Idea: have four results for the output image and users can pick what they need:

Name and tag would be used from Build(Run) spec output with tag defaulting to latest. The image-digest would be taken from status output, and would only be set if shipwright pushed the image, or if the build strategy did set the shp-image-digest result.

Based on future Build features, we can extend this with more results such as image-vulnerable.

We can also think about adding source-related results.

liangyuanpeng commented 1 year ago

I'm make a demo of gitops with shipwright and argocd.

In my case, i need this result to update image tag to git repo.

Once I figure out what's going on here I'll work for it.

Pending for #44

/assign