shipwright-io / triggers

Event-driven Shipwright Builds

Apache License 2.0

6 stars 7 forks source link

CustomRun support #31

Closed SaschaSchwarze0 closed 1 year ago

SaschaSchwarze0 commented 1 year ago

Changes

This PR introduces support for Tekton CustomRuns instead of Tekton Runs.

Submitter Checklist

[x] Includes tests if functionality changed/was added
[x] Includes docs if changes are user-facing
[x] Set a kind label on this PR
[x] Release notes block has been filled in, or marked NONE

Release Notes

Shipwright Triggers now supports Tekton Beta CustomRuns instead of Alpha Runs

otaviof commented 1 year ago

/assign @otaviof

otaviof commented 1 year ago

@SaschaSchwarze0 as we've spoken during grooming, let's drop the support for v1alpha1. Focusing on v1beta1 is a better future investment. I'll amend this PR ASAP.

otaviof commented 1 year ago

/hold

SaschaSchwarze0 commented 1 year ago

/unhold

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: otaviof, SaschaSchwarze0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/shipwright-io/triggers/blob/main/OWNERS)~~ [SaschaSchwarze0,otaviof] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment