shipwright-io / website

Creative Commons Attribution 4.0 International

3 stars 21 forks source link

Remove deprecated terms from config.toml #112

Open apoorvajagtap opened 3 months ago

apoorvajagtap commented 3 months ago

Changes

Removes deprecated variables from config.toml

Submitter Checklist

[ ] Includes tests if functionality changed/was added
[ ] Includes docs if changes are user-facing
[ ] Set a kind label on this PR
[x] Release notes block has been filled in, or marked NONE

Release Notes

NONE

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign saschaschwarze0 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/shipwright-io/website/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

apoorvajagtap commented 1 month ago

Hi @HeavyWombat linking the release notes & related issue where these changes were introduced. And I realized that I missed adding "term" as a replacement for "taxonomy" which might have led to the build failure. Let me know your thoughts!

Also, the errors indicate that the custom params on the language top level were deprecated in Hugo v0.112.0 and will be removed in Hugo 0.125.0. So, it is expected to put the value below [languages.en.params]. See https://gohugo.io/content-management/multilingual/#changes-in-hugo-01120