search

shipwright-io / website

Creative Commons Attribution 4.0 International
3 stars 21 forks source link

Add asciidoctor to website. #77

Closed adambkaplan closed 2 years ago

adambkaplan commented 2 years ago

Part of #75

adambkaplan commented 2 years ago

cc @rolfedh

adambkaplan commented 2 years ago

/approve

This basically will allow usage of both Markdown or AsciiDoc, right? Would mean that we don't have to migrate things.

Correct - we can keep existing markdown. Though switching everything would be good for consistency.

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/shipwright-io/website/blob/main/OWNERS)~~ [adambkaplan] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
rolfedh commented 2 years ago

Yes. As I understand it, with this enhancement, with can use markdown and asciidoc content. I would avoid having duplicate content in both file types. For example, with build.adoc and build.md, contributors might not know which file to modify.

rolfedh commented 2 years ago

In my tests, if you have two content files such as build.adoc and build.md, the markdown file "wins."

rolfedh commented 2 years ago

In my tests, if you have two content files such as build.adoc and build.md, the markdown file "wins."