minor compilation problems

shiranD / specializer

Python Library to convert vector fsts ro special fsts

Other

3 stars 1 forks source link

Open wjbyrne opened 7 years ago

wjbyrne commented 7 years ago

Hi, Its very possible I have a non-standard OpenFST install, but I had to make the following changes for successful compilation:

setup.py: add include_dirs = ["openfstpath/include"], to the extensions
specializer.cpp: replace #include "nlp/fst/script/getters.h" by `#include <fst/script/getters.h> Thanks for the tools and in particular for the unitTest examples! Bill

shiranD commented 7 years ago

Hi Bill,

Thanks for letting me know, I updated setup.py.
I learned that "nlp/fst/script/getters.h" is an internal source of google and should probably not be in the script at all in the openest version that is deployed outside of google. Perhaps you can overcome the compilation problem with the replacement you suggested, a bit earlier in the pipeline and apply the replacement already in fst.pxd.

Thanks! Shiran