Die with a useful message if the HTTP response is not succesful

shirkdog / pulledpork

Pulled Pork for Snort and Suricata rule management (from Google code)

GNU General Public License v2.0

417 stars 134 forks source link

Die with a useful message if the HTTP response is not succesful #290

Closed waterkip closed 6 years ago

waterkip commented 6 years ago

Spend quite some time to see why my request failed. Actually logging the URI and the statusline + responsecode is much easier. Pulledpork continued after errors, which isn't really nice. Log and die.

shirkdog commented 6 years ago

This looks good to me, there was one request that I allowed for warning and not dying, but I am in favor of detailing when things do not work as a fatal error.