search

shiroroku / LootBeams

A Minecraft mod that adds colorful and customizable loot beams to dropped items!
MIT License
17 stars 30 forks source link

[Bug] Crash when displaying Mana and Artifice Runescribing Recipe item #4

Closed Mrbysco closed 3 years ago

Mrbysco commented 3 years ago

Client info

Issue Description

A crash occurs when you drop a Runescribing Recipe item and LootBeams tries to render the name/tooltip. (Reporting on behalf of a friend)

Reproduce Steps

Drop a Mana and Artifice Runescribing Recipe on the floor.

Additional Information

Pastebin of Crashlog

shiroroku commented 3 years ago

from my testing this seems to be an issue with mana and artifice failing to load a recipe on its tooltip. it's hard to figure out what's really going on since mana and artifice isn't open source. i think the only fix for now is to blacklist the mod or item in lootbeam's config. you can also share this to the mod dev in hopes they can fix it.

blacklist = ["mana-and-artifice"] (disables lootbeams for all of mana and artifice's items) or blacklist = ["mana-and-artifice:runescribing_recipe_paper"] (disables lootbeams just for that item)

on the code side i think maybe they don't do a null check for PlayerEntity in getTooltipLines(@Nullable PlayerEntity, ITooltipFlag) since lootbeams passes in a null PlayerEntity. but i could be wrong.