shiroroku / TarotCards

A Minecraft mod that adds the 22 Major Arcana Tarot Cards with unique passive bonuses
https://www.curseforge.com/minecraft/mc-mods/tarot-cards
MIT License
2 stars 3 forks source link

Cards disappearing from tarot deck when entering creative mode (while Tarot Deck is in inventory) #12

Open tillasiren opened 1 year ago

tillasiren commented 1 year ago

Before submitting a bug please double check you are playing the latest release versions, and that this issue has not been submitted by someone else before, thank you.

Mod version: 1.18.2 1.4 Release

Describe the issue: Tarot Cards dissapear from within a tarot deck when entering creative mode

How to Reproduce:

  1. have a tarot deck with cards in it
  2. enter creative mode
  3. See error

Note: I have tested it both in a curio slot and out, it appears that at least the one instance I put it in a slot for curios it kept the single card I put in for testing purposes

shiroroku commented 1 year ago

i need more info, i cant seem to reproduce this

tillasiren commented 1 year ago
  1. Yes Let me just give you the link to the pack I am using (https://drive.google.com/file/d/1pdbI179Rv-2_VZLjRPGXIUZT2abCfMiy/view?usp=drive_link)
  2. none that I have seen
  3. Server, in my quick testing on a single player world it does not seem to occur. I did repeat it on my server though. It took a few tries. Prior to this every instance resulted in them being deleted. Upon further testing it appears that it occurs when the deck is in the inventory but not the hotbar or the curio slots. Though I did on at least two occasions get it to disappear while in the hotbar. I could not make it occur on singleplayer with a few minutes of testing
shiroroku commented 1 year ago

ok so it seems like this happens when on the server and when in creative which is really odd. this also is probably the same as #9. i looked more into it and i think it might be a forge issue with the way they use their IItemHandler capability, its meant more for blocks and not really items i guess?

basically: i gotta remake the tarot deck from scratch, which is gonna take a while as im working on other stuff at the moment as well.