shiroroku / TarotCards

A Minecraft mod that adds the 22 Major Arcana Tarot Cards with unique passive bonuses
https://www.curseforge.com/minecraft/mc-mods/tarot-cards
MIT License
2 stars 3 forks source link

Disappearing tarot cards with Relic #9

Open BlackAures1 opened 1 year ago

BlackAures1 commented 1 year ago

Mod version: tarotcards-1.19.2-1.2-release.jar relics-1.19.2-0.4.7.1

Describe the issue: When using the tarot vault, the cards may disappear inside. This happens in different situations, but 100% it happens when you use any skill from the Relics mod.

How to Reproduce: Video - https://cdn.discordapp.com/attachments/833848375383556106/1122576576547143830/Base_Profile_2023.06.25_-_20.18.16.08.mp4

Additional info: Modpack

shiroroku commented 1 year ago

this looks like it could be an issue with relics modifying inventory or copying the players itemstacks wrong. im still trying to dig through their code to figure out where. you can also submit an issue with them to hopefully fix this faster

SSKirillSS commented 1 year ago

Hi, I am the developer of the Relics mod.

I can't remember any line of code in the active ability interface that may affect player inventory. It uses entirely client-side code that scans CuriosAPI inventory for items, that have an ability instance. If any of relic ability was cast, it sends a packet to the server with the used ability and CuriosAPI slot ID. If CuriosAPI inventory is validated successfully and ability data matches, ability will be triggered on the server side.

Afaik all the active abilities code works only with RelicItem instances, so it shouldn't affect any other mod.

BlackAures1 commented 1 year ago

No news?

shiroroku commented 1 year ago

hmm no clue what it could be then. the tarot deck doesn't use any netcode, and it just implements forge's itemhandler capability for storing cards. maybe try testing another mod that has an item with inventory, such as thermals satchel, to see if it happens to it as well?

im thinking its possibly a different mod that changes vanilla/forge code