Open heyqule opened 4 years ago
Line 61 of src/StockSight/StockPriceListener.py You have D = [] which produces "list indices must be integers or slices, not str" Shouldn't line 61 be D = {}
Tweets arn't showing in Kibana. Shouldn't line 145 in src/StockSight/TweetListener.py "_id": redis_id, be "msg_id": redis_id,
Partial review considering the amount of commits for the single pull request. Consider creating feature branches more frequently so Chris can approve them faster. Thank you for dockerizing.
@caseykey
Thanks for the review. However, it seems you are reviewing the older commits. There were a lot of changes and experiments on earlier commits since this is my first Python project.
This pull request was submitted after I have done a lot of changes and I asked Chris' whether he's interested on dockerizing it. I initially did this as a Python practice. Submitting the pull request wasn't planned till the later stage.
Hey Chris
Here are the list of major changes. Let me know if there are things that needed to be change.
major changes
added
current issues: