BeanCounter breaks Postal (opening auction house/npc mail will destroy the attachment)

[ghost]

Hi there, since version https://github.com/shirsig/postal/commit/b3da5338761f9c19900fd6172e688800b7c5de45#diff-488427b9c215e3ca595810fb1905d189R190 of postal does not seem to check if mail (in my case it was mail returned from the auction house) still contains an item before deleting it. Right clicking to open the mail today resulted in me losing a couple a of relatively cheap idols I was trying to sell earlier. Just wanted to let you know before anyone accidentally deletes something more pricey. Otherwise great addon, keep up the good work, it's much appreciated.

[shirsig]

Are you certain? I've tested this a lot. What server is it?

[ghost]

I'm on Nefarian (classic-wow.org). I opened the mailbox, saw the idols returned by the auction house, right clicked all of them but they didn't appear in my inventory. Instead they just vanished. If you like I can try this again later with some really cheap trash items. Will take some time some for the auction to finish though.

[shirsig]

Sure they didn't stack or something? I tested it on both elysium and kronos both before uploading and now again and I cannot reproduce it. Not sure if the server could make a difference here.

[ghost]

Nope, I have no idols in the inventory at all. Testing now to confirm... done.

Right clicking inbox items sent by another character highlights them for a second, but doesn't open/loot the mail. Right clicking items returned by the auction house instantly destroys the message and the item.

[shirsig]

sure you have a clean install of the newest version? tried disabling all other addons?

[ghost]

Testing now with all other addons and Saved Variables removed...

So far it seems to loot items sent by other characters, but sometimes it takes multiple clicks before it opens the mail. Waiting to confirm items returned by auctions.

[shirsig]

It's supposed to be one click each for gold, item and text (only if available respectively)

[ghost]

I did some more testing and the bug seems to be caused by the BeanCounter addon, which is part of the auctioneer package. With BeanCounter disabled, Postal so far seems to work as expected. I have a raid to attend to now, but If I notice anything else I will post it later on.

[theoden-dd]

Confirm the bug on Elysium. My Twisted Chanter's Staff went Twisted Nether when I right-clicked on it after expiring from the AH.

Previously postal worked perfectly, but just today I tired to write down successful sells manually and recalled that there'll be no beancounter in aux. So I installed Auctioneer Pack as Simon recommended in the issue. It contained beancounter, just as planned... The rest of the story you know already.

If fixing the bug would be too tedious to accomplish, I think it deserves at least big red letters in the readme.

[shirsig]

It's not really a bug, just beancounter doing very bad things. Anyway, I've added makeshift fix that should prevent the deleting, and possibly other conflicts, though of course there is no solution to this kind of problem in general as other addons loaded earlier could always potentially modify api functions in arbitrary ways.

Could you confirm that it works, please? I don't have beancounter.

[theoden-dd]

In several minutes. While I'm checking it, quick question: @shirsig what tool do you use to track down your best sells? I wonder what it could be if not beancounter.

[theoden-dd]

Successfully collected items and money by right-clicking after beancounter was loaded.

However, still interested in your weapon choice. =)

[shirsig]

I get gold by farming mara/dm east